Skip to content

Add prerequisite to REX Pull Provider #4559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Lennonka merged 4 commits into from
Jan 14, 2026
Merged

Add prerequisite to REX Pull Provider #4559

Lennonka merged 4 commits into from
Jan 14, 2026

Conversation

@maximiliankolb
Copy link
Contributor

@maximiliankolb maximiliankolb commented Jan 2, 2026 •
edited
Loading

What changes are you introducing?

  • Show "Enabling REX" for foreman-el and foreman-deb builds (for Katello-like builds, it's enabled by default on Foreman Server)
  • Show "Enabling REX Pull provider" for all Katello-like builds
  • Add prerequisite that you need to enabled REX on your Smart Proxy Server if you want to configure REX Pull Provider on it.

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

The third item is the result of a bug report.

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Needs TECH ACK on the following assumptions which I could non conclusively verify in code:

  • Satellite Server and Capsule Servers always have REX enabled -> They do by default. It's possible to disable it.
  • orcharhino Server has REX enabled by default
  • orcharhino Proxy Server does not have REX enabled by default
  • Foreman+Katello Server has REX enabled by default
  • Foreman+Katello Smart Proxy Servers do not have REX enabled by default (due to line 7)
  • REX Pull Provider is for Katello-like builds only (due to line 11)

Contributor checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.17/Katello 4.19
  • Foreman 3.16/Katello 4.18 (Satellite 6.18; orcharhino 7.6)
  • Foreman 3.15/Katello 4.17
  • Foreman 3.14/Katello 4.16 (Satellite 6.17; orcharhino 7.4; orcharhino 7.5)
  • Foreman 3.13/Katello 4.15 (EL9 only)
  • Foreman 3.12/Katello 4.14 (Satellite 6.16; orcharhino 7.2 on EL9 only; orcharhino 7.3)
  • We do not accept PRs for Foreman older than 3.12.

@github-actions github-actions bot added Needs tech review Requires a review from the technical perspective Needs style review Requires a review from docs style/grammar perspective Needs testing Requires functional testing labels Jan 2, 2026
@maximiliankolb maximiliankolb changed the title Show REX Pull Provider notes and prerequisite Add prerequisite to REX Pull Provider Jan 2, 2026
@github-actions
Copy link

github-actions bot commented Jan 2, 2026 •
edited
Loading

The PR preview for adc65c6 is available at theforeman-foreman-documentation-preview-pr-4559.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@lhellebr
Copy link
Contributor

lhellebr commented Jan 5, 2026 •
edited
Loading

Satellite Server and Capsule Servers always have REX enabled

They do by default. It's possible to disable it.

@aneta-petrova aneta-petrova added style review done No issues from docs style/grammar perspective and removed Needs style review Requires a review from docs style/grammar perspective labels Jan 5, 2026
sbernhard
sbernhard approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tech: done.
thanks

@maximiliankolb
Show enabling REX Pull Provider for Katello-like builds
024b10d 
Foreman+Katello and Katello-like builds have REX on Foreman Server
enabled by default.
@maximiliankolb
Show REX on Smart Proxy Servers for orcharhino builds
f2a4d6d
@maximiliankolb
Require REX to enable REX Pull Provider
ebf74e4 
On Satellite, REX is always enabled on Foreman Server and Smart Proxy
Servers by default.
@maximiliankolb
fixup! Require REX to enable REX Pull Provider
adc65c6
@maximiliankolb maximiliankolb force-pushed the pull_provider_requires_rex branch from 2dd5ac0 to adc65c6 Compare January 13, 2026 07:10
maximiliankolb
maximiliankolb commented Jan 13, 2026
View reviewed changes
Copy link
Contributor Author

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied both suggestions and rebased to HEAD of "master". Needs re-review.

@maximiliankolb maximiliankolb added tech review done No issues from the technical perspective and removed Needs tech review Requires a review from the technical perspective Needs testing Requires functional testing labels Jan 13, 2026
sbernhard
sbernhard approved these changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@sbernhard sbernhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tech: fine!
Thanks.

Lennonka
Lennonka reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure about the PR as it currently is.
Questions below.

@Lennonka Lennonka added the Waiting on contributor Requires an action from the author label Jan 14, 2026
Lennonka
Lennonka approved these changes Jan 14, 2026
View reviewed changes
Copy link
Contributor

@Lennonka Lennonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've missed things before and figured them out. All good!

@Lennonka Lennonka removed the Waiting on contributor Requires an action from the author label Jan 14, 2026
@Lennonka Lennonka merged commit 352946a into theforeman:master Jan 14, 2026
10 checks passed
Lennonka pushed a commit that referenced this pull request Jan 14, 2026
@maximiliankolb @Lennonka
Add prerequisite to REX Pull Provider (#4559)
9f230aa 
* Show enabling REX Pull Provider for Katello-like builds

Foreman+Katello and Katello-like builds have REX on Foreman Server
enabled by default.

* Show REX on Smart Proxy Servers for orcharhino builds

* Require REX to enable REX Pull Provider

On Satellite, REX is always enabled on Foreman Server and Smart Proxy
Servers by default.

* fixup! Require REX to enable REX Pull Provider
Lennonka pushed a commit that referenced this pull request Jan 14, 2026
@maximiliankolb @Lennonka
Add prerequisite to REX Pull Provider (#4559)
4fd3246 
* Show enabling REX Pull Provider for Katello-like builds

Foreman+Katello and Katello-like builds have REX on Foreman Server
enabled by default.

* Show REX on Smart Proxy Servers for orcharhino builds

* Require REX to enable REX Pull Provider

On Satellite, REX is always enabled on Foreman Server and Smart Proxy
Servers by default.

* fixup! Require REX to enable REX Pull Provider
@Lennonka
Copy link
Contributor

Lennonka commented Jan 14, 2026

Cherry picked:

@maximiliankolb maximiliankolb deleted the pull_provider_requires_rex branch January 14, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lennonka Lennonka Lennonka approved these changes

@aneta-petrova aneta-petrova Awaiting requested review from aneta-petrova

+1 more reviewer

@sbernhard sbernhard sbernhard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maximiliankolb @lhellebr @Lennonka @aneta-petrova @sbernhard